Fix sidebar issues hapenning when changing from sidebar-narrow-unfoldable desktop to mobile #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able desktop to mobile
|
What are your thoughts @mrholek ? |
|
Indeed, the issue also happens on |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When the sidebar is visible in unfoldable state and the browser is reduced until modile dimensions, there is a strange animation which occurs due to margin-left differencies.
After researching about this topic, I concluded that the main issue is caused by the
visiblestate of theCSidebarbecause it is the same for Desktop and for Mobile.I manage to fix the code by creating a new state called
mobileVisiblewhich isFalseby default and it is only modified when the browser has mobile dimensions. It notifies all the visible changes to component by theonVisibleChangefunction, so it continious working properly and the annoying effect disappears.