Skip to content

TargetRid, TargetArchitecture and TargetOS should always be passed to repo projects #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akoeplinger opened this issue Apr 10, 2024 · 3 comments · Fixed by dotnet/sdk#48024
Closed

TargetRid, TargetArchitecture and TargetOS should always be passed to repo projects #4313

akoeplinger opened this issue Apr 10, 2024 · 3 comments · Fixed by dotnet/sdk#48024
Labels
area-unified-build

Comments

@akoeplinger
Copy link
Member

https://dev.azure.com/dnceng/internal/_build/results?buildId=2426882&view=results

There's multiple issues:

  1. wpf in the "Windows x64" job is building x86 assets
  2. windowsdesktop builds x64 assets in the "Windows x86" job

We're not passing TargetArchitecture to the repo builds for these projects, we should do so. @ViktorHofer suggested we should probably always pass TargetOS and TargetArchitecture.
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@akoeplinger
Copy link
Member Author

wpf also doesn't look at TargetArchitecture, it only uses Platform right now: #4314

@ViktorHofer
Copy link
Member

While ideally all repos use that common set of inputs that presumably requires more work and some more standardization in the Arcade SDK and scripts. Meanwhile for WPF we could just set the Platform property in wpf.proj in the VMR orchestrator.

@akoeplinger akoeplinger mentioned this issue Apr 10, 2024
Merged
akoeplinger added a commit to dotnet/installer that referenced this issue Apr 10, 2024
@akoeplinger
[VMR] Pass architecture to wpf and windowsdesktop repos (#19393)
310e0ca 
Works around dotnet/source-build#4313 and dotnet/source-build#4314
MiYanni pushed a commit to dotnet/sdk that referenced this issue Apr 25, 2024
@akoeplinger
[VMR] Pass architecture to wpf and windowsdesktop repos (#19393)
e52ff23 
Works around dotnet/source-build#4313 and dotnet/source-build#4314
ViktorHofer pushed a commit to dotnet/sdk that referenced this issue May 7, 2024
@akoeplinger
[VMR] Pass architecture to wpf and windowsdesktop repos (#19393)
249b5e5 
Works around dotnet/source-build#4313 and dotnet/source-build#4314
@ViktorHofer ViktorHofer changed the title TargetArchitecture and TargetOS should always be passed to repo projects TargetRid, TargetArchitecture and TargetOS should always be passed to repo projects Mar 30, 2025
@ViktorHofer ViktorHofer mentioned this issue Mar 30, 2025
Merged
1 task
ViktorHofer added a commit to dotnet/sdk that referenced this issue Mar 31, 2025
@ViktorHofer
Flow TargetArchitecture and TargetOS to inner repos
533cd50 
Fixes dotnet/source-build#4313

Now especially necessary as the RID specific publishing mode depends on TargetArchitecture being available in the inner repo build.
@ViktorHofer ViktorHofer mentioned this issue Mar 31, 2025
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in .NET Source Build Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-unified-build
Projects
.NET Source Build
Archived in project
.NET Unified Build
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flow TargetArchitecture and TargetOS to inner repos dotnet/sdk
2 participants
@akoeplinger @ViktorHofer