Skip to content

Implement a strategy to publish productVersion.txt produced by the vertical build #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MilenaHristova opened this issue Sep 9, 2024 · 0 comments · Fixed by dotnet/sdk#48105
Assignees

Comments

@MilenaHristova
Copy link

Related issues: #4199 and #4157

One vertical creates multiple productVersion.txt files - Sdk\[VERSION]\productVersion.txt, WindowsDesktop\[VERSION]\productVersion.txt, aspnetcore\Runtime\[VERSION]\productVersion.txt. Those files are used by dotnet-install scripts.

In the final build pass we merge the assets from all verticals and copy them to a flat layout in BlobArtifacts folder. We can't have multiple files with the same filename. We should figure out a way to select the files to publish and publish them in the locations expected by dotnet-install scripts or alternatively, modify the scripts.

There is also Sdk\[VERSION]\sdk-productVersion.txt, WindowsDesktop\[VERSION]\windowsdesktop-productVersion.txt, aspnetcore\Runtime\[VERSION]\aspnetcore-productVersion.txt that could potentially be used instead of productVersion.txt

@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Sep 9, 2024
@MichaelSimons MichaelSimons added area-unified-build and removed area-build Improvements in source-build's own build process untriaged labels Sep 12, 2024
@mmitche mmitche moved this to Ready in .NET Unified Build Mar 6, 2025
@mmitche mmitche moved this from Ready to In Progress in .NET Unified Build Mar 18, 2025
jkoritzinsky added a commit to jkoritzinsky/dotnet-sdk that referenced this issue Apr 2, 2025
As all of our productVersion.txt files are identical, we can publish all of them as they'll all have the same content

Fixes dotnet/source-build#4596
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Unified Build Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants