Skip to content

Component .pkgs that were signed using SignTool are being reported as "not signed" #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellahathaway opened this issue Feb 7, 2025 · 4 comments
Assignees

Comments

@ellahathaway
Copy link
Member

Related to dotnet/arcade#15489

After adding the SignCheck logic to check .pkg signatures, I discovered that component (nested) pkgs are being reported as "unsigned". I validated this locally by pulling a signed installer pkg, unpacking the installer, and verifying the component pkg. When I did this, the component pkg was reported to not have a signature. This is despite SignTool + MicroBuild binlogs showing that the component pkg was submitted for signing and was signed successfully.

Interestingly, when I then repacked the installer pkg and reverified it's signature, it was reported to not be signed. This suggests that the repack logic is likely modifying the package.

We should investigate this further.

cc @mmitche

@ellahathaway
Copy link
Member Author

@mmitche - Heads up that I added this to the board under preview4 since I think this is something that should get addressed by that deadline.

@mmitche
Copy link
Member

mmitche commented Mar 18, 2025

Yep thanks.

@mmitche mmitche self-assigned this Mar 25, 2025
@mmitche mmitche moved this from Ready to In Progress in .NET Unified Build Mar 28, 2025
@mmitche
Copy link
Member

mmitche commented Mar 28, 2025

The pkgs lose their signature on unpack. That said, we do need to properly notarize them first, so doing that. dotnet/runtime#114027 and dotnet/sdk#47996

@mmitche
Copy link
Member

mmitche commented Apr 1, 2025

Closing in favor of #4994

@mmitche mmitche closed this as completed Apr 1, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Unified Build Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants