Skip to content

VMR assemblies that are authenticode signed but not strong-named #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellahathaway opened this issue Mar 27, 2025 · 7 comments
Closed

VMR assemblies that are authenticode signed but not strong-named #4985

ellahathaway opened this issue Mar 27, 2025 · 7 comments
Assignees

Comments

@ellahathaway
Copy link
Member

There are three assemblies in the VMR that are being reported as having valid Authenticode signatures but are not strong-named:

  • Valleysoft.DockerCredsProvider.dll
  • ILVerify.dll
  • ILCompiler.Build.Tasks.dll

We should determine if we expect these to be strong-named or not. If we do not expect them to be strong-named, we will need to implement a fix.

@mmitche
Copy link
Member

mmitche commented Mar 28, 2025

Valleysoft.DockerCredsProvider.dll should not be strong named since we didn't build it. @jkoritzinsky do you happen to know about:

ILVerify.dll
ILCompiler.Build.Tasks.dll

?

@ellahathaway
Copy link
Member Author

Sounds good. dotnet/arcade#15682 (plus an entry in the VMR exclusions file) will take care of the validation alerting to Valleysoft.DockerCredsProvider.dll

@mmitche mmitche moved this from Ready to In Progress in .NET Unified Build Mar 31, 2025
@mmitche
Copy link
Member

mmitche commented Mar 31, 2025

Close when you're ready to.

@ellahathaway
Copy link
Member Author

do you happen to know about:

ILVerify.dll
ILCompiler.Build.Tasks.dll

@jkoritzinsky - friendly ping on the earlier question :)

@mmitche
Copy link
Member

mmitche commented Apr 1, 2025

@ericstj Can also probably answer the above question too.

@ericstj
Copy link
Member

ericstj commented Apr 1, 2025

I checked my local runtime build and found that they are not strong-named there. Also checked in the product bits and found they were not signed. Seems intentional to me.

Here's what seems to make that setting:
https://github.com/dotnet/runtime/blob/bbc50e511150368fd10f56783c48aa3a04f1f5d3/src/coreclr/tools/Directory.Build.props#L5

@mmitche
Copy link
Member

mmitche commented Apr 1, 2025

Thanks @ericstj

@mmitche mmitche closed this as completed Apr 1, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Unified Build Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants