-
Notifications
You must be signed in to change notification settings - Fork 134
VMR assemblies that are authenticode signed but not strong-named #4985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Valleysoft.DockerCredsProvider.dll should not be strong named since we didn't build it. @jkoritzinsky do you happen to know about:
? |
Sounds good. dotnet/arcade#15682 (plus an entry in the VMR exclusions file) will take care of the validation alerting to |
Close when you're ready to. |
@jkoritzinsky - friendly ping on the earlier question :) |
@ericstj Can also probably answer the above question too. |
I checked my local runtime build and found that they are not strong-named there. Also checked in the product bits and found they were not signed. Seems intentional to me. Here's what seems to make that setting: |
Thanks @ericstj |
There are three assemblies in the VMR that are being reported as having valid Authenticode signatures but are not strong-named:
We should determine if we expect these to be strong-named or not. If we do not expect them to be strong-named, we will need to implement a fix.
The text was updated successfully, but these errors were encountered: