Skip to content

Unsigned Mac VMR artifacts #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ellahathaway opened this issue Mar 31, 2025 · 7 comments
Closed

Unsigned Mac VMR artifacts #4994

ellahathaway opened this issue Mar 31, 2025 · 7 comments
Assignees

Comments

@ellahathaway
Copy link
Member

Pipeline run

There are 60 unique filenames that are being reported as "unsigned" by SignCheck on mac:

Files without extensions:
Mono
crossgen2
ilasm
ilc
ildasm
llc
mono-aot-cross
opt
singlefilehost

.dwarf:
Mono.dwarf
apphost.dwarf
createdump.dwarf
dotnet.dwarf
ilasm.dwarf
ildasm.dwarf
libSystem.Globalization.Native.dylib.dwarf
libSystem.IO.Compression.Native.dylib.dwarf
libSystem.IO.Ports.Native.dylib.dwarf
libSystem.Native.dylib.dwarf
libSystem.Net.Security.Native.dylib.dwarf
libSystem.Security.Cryptography.Native.Apple.dylib.dwarf
libSystem.Security.Cryptography.Native.OpenSsl.dylib.dwarf
libclrgc.dylib.dwarf
libclrgcexp.dylib.dwarf
libclrjit.dylib.dwarf
libcoreclr.dylib.dwarf
libhostfxr.dylib.dwarf
libhostpolicy.dylib.dwarf
libmono-component-debugger.dylib.dwarf
libmono-component-diagnostics_tracing.dylib.dwarf
libmono-component-hot_reload.dylib.dwarf
libmono-component-marshal-ilgen.dylib.dwarf
libmonosgen-2.0.dylib.dwarf
libmscordaccore.dylib.dwarf
libmscordbi.dylib.dwarf
libnethost.dylib.dwarf
mono-aot-cross.dwarf
singlefilehost.dwarf

.o
libbootstrapper.o
libbootstrapperdll.o

.pkg
com.microsoft.dotnet.dev.x.y.z.component.osx.arch.pkg
com.microsoft.dotnet.hostfxr.x.y.z.component.osx.arch.pkg
com.microsoft.dotnet.pack.apphost.x.y.z.component.osx.arch.pkg
com.microsoft.dotnet.pack.targeting.x.y.z.component.osx.arch.pkg
com.microsoft.dotnet.sharedframework.Microsoft.NETCore.App..component.osx.arch.pkg <- this one is missing a version?
com.microsoft.dotnet.sharedhost.x.y.z.component.osx.arch.pkg
com.microsoft.standard.pack.targeting.x.y.z.component.osx.arch.pkg
dotnet-host-internal-x.y.z-osx-arch.pkg
dotnet-hostfxr-internal-x.y.z-osx-arch.pkg
dotnet-runtime-internal-x.y.z-osx-arch.pkg

@mmitche
Copy link
Member

mmitche commented Mar 31, 2025

  • The com.* packages can be eliminated if these are just a result of unpacking the .pkg. I haven't been able to peek at the nested signature after unpacking.
  • The internal* packages can be unsigned. they are chained in to the final .pkgs later on.

@akoeplinger
Copy link
Member

akoeplinger commented Apr 1, 2025

com.microsoft.dotnet.sharedframework.Microsoft.NETCore.App..component.osx.arch.pkg <- this one is missing a version?

I checked and this is already the case in 9.0.202 and 8.0.407 so likely always been this way and not critical. Would be nice to fix it though. dotnet/sdk#48059

@akoeplinger
Copy link
Member

We should exclude the .dwarf files, these are debugging symbols and we're not signing .pdbs either

@akoeplinger
Copy link
Member

The llc/opt/mono-aot-cross look like real issues that probably also happen in the current official build.

akoeplinger added a commit to dotnet/sdk that referenced this issue Apr 1, 2025
MicrosoftNETCoreAppPackageVersion was removed years ago in dotnet/installer@0f52aed

Discovered in dotnet/source-build#4994
@mmitche
Copy link
Member

mmitche commented Apr 1, 2025

The llc/opt/mono-aot-cross look like real issues that probably also happen in the current official build.

I'll add these to my sign/notarize PR in runtime.

@mmitche
Copy link
Member

mmitche commented Apr 1, 2025

Additional unsigned mac executables covered by dotnet/runtime#114027

@mmitche
Copy link
Member

mmitche commented Apr 7, 2025

Just waiting on runtime flow to complete so that we can merge the SDK PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants