Microsoft.TestPlatform and Microsoft.TestPlatform.Portable packages missing from VMR

[ViktorHofer]

    <AssetMapping Id="Microsoft.TestPlatform" Type="Package">
      <BaseFile>D:\a\_work\1\a\base-assets\vstest\shipping\packages\Microsoft.TestPlatform.17.14.0-preview-25181-02.nupkg</BaseFile>
      <EvaluationErrors />
      <Issues>
        <Issue Type="MissingShipping" Description="Package 'Microsoft.TestPlatform' is missing in the VMR." />
      </Issues>
    </AssetMapping>
    <AssetMapping Id="Microsoft.TestPlatform.Portable" Type="Package">
      <BaseFile>D:\a\_work\1\a\base-assets\vstest\shipping\packages\Microsoft.TestPlatform.Portable.17.14.0-preview-25181-02.nupkg</BaseFile>
      <EvaluationErrors />
      <Issues>
        <Issue Type="MissingShipping" Description="Package 'Microsoft.TestPlatform.Portable' is missing in the VMR." />
      </Issues>
    </AssetMapping>
    <AssetMapping Id="assets/symbols/Microsoft.TestPlatform.17.14.0-preview-25181-02.symbols.nupkg" Type="Blob">
      <BaseFile>D:\a\_work\1\a\base-assets\vstest\shipping\assets/symbols/Microsoft.TestPlatform.17.14.0-preview-25181-02.symbols.nupkg</BaseFile>
      <EvaluationErrors />
      <Issues>
        <Issue Type="MissingShipping" Description="Blob 'assets/symbols/Microsoft.TestPlatform.17.14.0-preview-25181-02.symbols.nupkg' is missing in the VMR." />
      </Issues>
    </AssetMapping>
    <AssetMapping Id="assets/symbols/Microsoft.TestPlatform.Portable.17.14.0-preview-25181-02.symbols.nupkg" Type="Blob">
      <BaseFile>D:\a\_work\1\a\base-assets\vstest\shipping\assets/symbols/Microsoft.TestPlatform.Portable.17.14.0-preview-25181-02.symbols.nupkg</BaseFile>
      <EvaluationErrors />
      <Issues>
        <Issue Type="MissingShipping" Description="Blob 'assets/symbols/Microsoft.TestPlatform.Portable.17.14.0-preview-25181-02.symbols.nupkg' is missing in the VMR." />
      </Issues>
    </AssetMapping>

[ViktorHofer]

Even though it might not matter, the package should get produced in VMR UB builds, just not in source-build: https://github.com/microsoft/vstest/blob/debb6b8de4f51c50aba52ca9fe5f559846f45cfb/src/package/Microsoft.TestPlatform.Portable/Microsoft.TestPlatform.Portable.csproj#L19-L20

Same for the other.

[ViktorHofer]

Submitted dotnet/dotnet#171 to see if computer says yes.

[ViktorHofer]

OK yeah we can't build those packages in the VMR because we depend on the LICENSE_VS file that is cloaked out in the VMR: https://github.com/microsoft/vstest/blob/main/src/package/licenses/LICENSE_VS.txt

Could we exclude the license from the two packages, given that we don't publish them? @mmitche
If the answer is no, then let's baseline the entries.

[MichaelSimons]

Could we exclude the license from the two packages, given that we don't publish them?

Perhaps this is what you meant, but rather than excluding a license, perhaps you could use the same open source license that source-build uses.

[mmitche]

Do those packages get referenced anywhere? Are you thinking to produce them just to be safe, or because they are needed?

[ViktorHofer]

Yeah, it doesn't really matter. I felt like building the packages and reducing the asset diff between MSFT and VMR builds is the cleaner approach.