Fixed MenuItem Header alignment wrt to Icons #10735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (4)
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/MenuItem.xaml: Language not supported
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Dark.xaml: Language not supported
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.HC.xaml: Language not supported
- src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Light.xaml: Language not supported
dotnet-policy-service
bot
added
the
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10735 +/- ##
===================================================
+ Coverage 11.26276% 12.87183% +1.60906%
===================================================
Files 3315 3316 +1
Lines 665228 665321 +93
Branches 74668 74667 -1
===================================================
+ Hits 74923 85639 +10716
+ Misses 589002 577371 -11631
- Partials 1303 2311 +1008
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/MenuItem.xaml
Outdated
Show resolved
Hide resolved
|
LGTM |
siagupta0202
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9980
Description
In the current MenuItem Fluent styles, the Icon column didn't share width among the different MenuItems. Due to this, the Header content presenter gets misaligned.
Customer Impact
Improves usability and speeds up visual scanning of the UI
Regression
Technically no, but as compared to Aero2 styles this is a regression in Fluent styles.
Testing
Local app testing.
Risk
Minimal
Microsoft Reviewers: Open in CodeFlow