-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls: Added metadata to the Controls project to enable publishing to NuGet #16611
base: main
Are you sure you want to change the base?
Conversation
We should do this after v4 or even later. What do you think? |
We can move forward with this as soon as the versioning system is agreed on. |
If you'd like to publish when you publish preview or stable thru Files CD, we can add a parameter text box to input the version. If empty, don't publish; otherwise, try publish with that version string. |
This shouldn't be tied to app releases. We may have a newer control ready for release before an app update, and on the other hand, we may want to release the app without updating the controls. It's best to handle this as a separate action. |
@yaira2 when you approve you'll need to give the bot access to the repo |
Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
[skip ci]
Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
[skip ci]
[skip ci]
[skip ci]
[skip ci]
[skip ci]
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com> Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
[skip ci] Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com> Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com> Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
|
||
jobs: | ||
build: | ||
runs-on: windows-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runs-on: windows-latest | |
runs-on: windows-latest | |
environment: Deployments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would strongly recommend against using the same environment for different things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app CD workflow and UI controls CD workflow should be in different environments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grouped them together as they are both deployments. We can separate them if there is a good reason to, but I may have to generate new tokens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will need to be separate as the CD for the app requires approval but the CD for the Controls project won't (as it will add extra hassle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The controls project will require approval as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it makes sense to put them in separate deployment environments as they deploy to separate deployment environments
Co-authored-by: Yair <39923744+yaira2@users.noreply.github.com> Signed-off-by: Lamparter <71598437+Lamparter@users.noreply.github.com>
Resolved / Related Issues
Discussed on Discord
Steps used to test these changes
WHEN PR IS ACCEPTED (NOT BEFORE)
NuGet
main
and PR configurationsCurrentVersion.props
files-community-bot[bot]
token