Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls: Added metadata to the Controls project to enable publishing to NuGet #16611
base: main
Are you sure you want to change the base?
Controls: Added metadata to the Controls project to enable publishing to NuGet #16611
Changes from all commits
4550b6a
5656e61
ab85e84
dc679ab
35774d2
8755b58
8333345
07c4217
b60e8bf
e1b9694
30be097
9c5fdef
0b222a6
16c106c
3bd08fc
47bbe68
6135043
e38ab75
d17dc44
ca1b6e2
1a9d698
67e41e0
aa407da
7e3f286
5045871
0f616d2
61f221c
0f492a4
6f2f9f2
6c3623f
307a292
cb14db7
0b7ac74
84bbad3
3e5c8df
257757d
44d6400
a19aaa0
1c2e910
518b1ad
007069d
f96a846
90eb94b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be switched to files-community.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware, this is one of the things that needs to be done right before merge. Changing this would mean I can't test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If everything else is ready, we should make this change and merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Fingers crossed it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow should automatically run after bumping the version number. However, it should not run every time we merge a PR into
main
, otherwise it will create extra noise which we wish to avoid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't, it will only run on every push to main that has a change to CurrentVersion.props.
Changing this before merge will make it impossible to test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we test by bumping the version number?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant we can test by modifying
CurrentVersion.props
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it's nicer to test here by just any commit.
Regardless it won't work because there isn't a token yet.
It doesn't matter at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The token is already configured, if everything else is ready, we should make this change and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would strongly recommend against using the same environment for different things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app CD workflow and UI controls CD workflow should be in different environments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I grouped them together as they are both deployments. We can separate them if there is a good reason to, but I may have to generate new tokens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They will need to be separate as the CD for the app requires approval but the CD for the Controls project won't (as it will add extra hassle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The controls project will require approval as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it makes sense to put them in separate deployment environments as they deploy to separate deployment environments