Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality; Added global files to the solution file #16929

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Code Quality; Added global files to the solution file #16929

wants to merge 1 commit into from

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 14, 2025 •
edited
Loading

Resolved / Related Issues

None

Steps used to test these changes

None

image

@0x5bfa
Update Files.slnx
21eb115 
Revert "Update Files.slnx"

This reverts commit 17758bb.

Update
@Lamparter
Copy link
Contributor

Lamparter commented Mar 14, 2025 •
edited
Loading

I don't like the name .solution
My reasoning for #16815 was that the files apply everywhere, and so should be in all the projects.
A better idea would be to put them in an appropriate build folder, e.g. eng/, but that would create a greater inconsistency with the actual file structure like platforms/ and core/ do (those folders don't actually exist)

@0x5bfa
Copy link
Member Author

0x5bfa commented Mar 16, 2025 •
edited
Loading

the goal here is not to match the folder structure but to keep developer experience the greatest possible. contrary, i dont encourage the team to have "core" and "platform" folders since they unnecessarily make nested structure and hide the projects inside. that said, theres still room to discuss the name of this virtual folder.

@yaira2 please review, @hez2010 based on your review before, is this good for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs - code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x5bfa @Lamparter @yaira2