Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Enforced centralized Strings class in misc actions #16944

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Code Quality: Enforced centralized Strings class in misc actions #16944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 50 additions & 50 deletions src/Files.App/Actions/Display/GroupAction.cs
View file
Original file line number Diff line number Diff line change
@@ -21,10 +21,10 @@ protected override GroupOption GroupOption
=> GroupOption.Name;

public override string Label
=> "Name".GetLocalizedResource();
=> Strings.Name.GetLocalizedResource();

public override string Description
=> "GroupByNameDescription".GetLocalizedResource();
=> Strings.GroupByNameDescription.GetLocalizedResource();
}

internal sealed partial class GroupByDateModifiedAction : GroupByAction
@@ -33,10 +33,10 @@ protected override GroupOption GroupOption
=> GroupOption.DateModified;

public override string Label
=> "DateModifiedLowerCase".GetLocalizedResource();
=> Strings.DateModifiedLowerCase.GetLocalizedResource();

public override string Description
=> "GroupByDateModifiedDescription".GetLocalizedResource();
=> Strings.GroupByDateModifiedDescription.GetLocalizedResource();
}

internal sealed partial class GroupByDateCreatedAction : GroupByAction
@@ -45,10 +45,10 @@ protected override GroupOption GroupOption
=> GroupOption.DateCreated;

public override string Label
=> "DateCreated".GetLocalizedResource();
=> Strings.DateCreated.GetLocalizedResource();

public override string Description
=> "GroupByDateCreatedDescription".GetLocalizedResource();
=> Strings.GroupByDateCreatedDescription.GetLocalizedResource();
}

internal sealed partial class GroupBySizeAction : GroupByAction
@@ -57,10 +57,10 @@ protected override GroupOption GroupOption
=> GroupOption.Size;

public override string Label
=> "Size".GetLocalizedResource();
=> Strings.Size.GetLocalizedResource();

public override string Description
=> "GroupBySizeDescription".GetLocalizedResource();
=> Strings.GroupBySizeDescription.GetLocalizedResource();
}

internal sealed partial class GroupByTypeAction : GroupByAction
@@ -69,10 +69,10 @@ protected override GroupOption GroupOption
=> GroupOption.FileType;

public override string Label
=> "Type".GetLocalizedResource();
=> Strings.Type.GetLocalizedResource();

public override string Description
=> "GroupByTypeDescription".GetLocalizedResource();
=> Strings.GroupByTypeDescription.GetLocalizedResource();
}

internal sealed partial class GroupBySyncStatusAction : GroupByAction
@@ -81,10 +81,10 @@ protected override GroupOption GroupOption
=> GroupOption.SyncStatus;

public override string Label
=> "SyncStatus".GetLocalizedResource();
=> Strings.SyncStatus.GetLocalizedResource();

public override string Description
=> "GroupBySyncStatusDescription".GetLocalizedResource();
=> Strings.GroupBySyncStatusDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.CloudDrive;
@@ -96,10 +96,10 @@ protected override GroupOption GroupOption
=> GroupOption.FileTag;

public override string Label
=> "FileTags".GetLocalizedResource();
=> Strings.FileTags.GetLocalizedResource();

public override string Description
=> "GroupByTagDescription".GetLocalizedResource();
=> Strings.GroupByTagDescription.GetLocalizedResource();
}

internal sealed partial class GroupByOriginalFolderAction : GroupByAction
@@ -108,10 +108,10 @@ protected override GroupOption GroupOption
=> GroupOption.OriginalFolder;

public override string Label
=> "OriginalFolder".GetLocalizedResource();
=> Strings.OriginalFolder.GetLocalizedResource();

public override string Description
=> "GroupByOriginalFolderDescription".GetLocalizedResource();
=> Strings.GroupByOriginalFolderDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.RecycleBin;
@@ -123,10 +123,10 @@ protected override GroupOption GroupOption
=> GroupOption.DateDeleted;

public override string Label
=> "DateDeleted".GetLocalizedResource();
=> Strings.DateDeleted.GetLocalizedResource();

public override string Description
=> "GroupByDateDeletedDescription".GetLocalizedResource();
=> Strings.GroupByDateDeletedDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.RecycleBin;
@@ -138,10 +138,10 @@ protected override GroupOption GroupOption
=> GroupOption.FolderPath;

public override string Label
=> "FolderPath".GetLocalizedResource();
=> Strings.FolderPath.GetLocalizedResource();

public override string Description
=> "GroupByFolderPathDescription".GetLocalizedResource();
=> Strings.GroupByFolderPathDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.Library or ContentPageTypes.SearchResults;
@@ -209,10 +209,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Year;

public override string Label
=> "Year".GetLocalizedResource();
=> Strings.Year.GetLocalizedResource();

public override string Description
=> "GroupByDateModifiedYearDescription".GetLocalizedResource();
=> Strings.GroupByDateModifiedYearDescription.GetLocalizedResource();
}

internal sealed partial class GroupByDateModifiedMonthAction : GroupByDateAction
@@ -224,10 +224,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Month;

public override string Label
=> "Month".GetLocalizedResource();
=> Strings.Month.GetLocalizedResource();

public override string Description
=> "GroupByDateModifiedMonthDescription".GetLocalizedResource();
=> Strings.GroupByDateModifiedMonthDescription.GetLocalizedResource();
}

internal sealed partial class GroupByDateModifiedDayAction : GroupByDateAction
@@ -239,10 +239,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Day;

public override string Label
=> "Day".GetLocalizedResource();
=> Strings.Day.GetLocalizedResource();

public override string Description
=> "GroupByDateModifiedDayDescription".GetLocalizedResource();
=> Strings.GroupByDateModifiedDayDescription.GetLocalizedResource();
}

internal sealed partial class GroupByDateCreatedYearAction : GroupByDateAction
@@ -254,10 +254,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Year;

public override string Label
=> "Year".GetLocalizedResource();
=> Strings.Year.GetLocalizedResource();

public override string Description
=> "GroupByDateCreatedYearDescription".GetLocalizedResource();
=> Strings.GroupByDateCreatedYearDescription.GetLocalizedResource();
}

internal sealed partial class GroupByDateCreatedMonthAction : GroupByDateAction
@@ -269,10 +269,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Month;

public override string Label
=> "Month".GetLocalizedResource();
=> Strings.Month.GetLocalizedResource();

public override string Description
=> "GroupByDateCreatedMonthDescription".GetLocalizedResource();
=> Strings.GroupByDateCreatedMonthDescription.GetLocalizedResource();
}

internal sealed partial class GroupByDateCreatedDayAction : GroupByDateAction
@@ -284,10 +284,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Day;

public override string Label
=> "Day".GetLocalizedResource();
=> Strings.Day.GetLocalizedResource();

public override string Description
=> "GroupByDateCreatedDayDescription".GetLocalizedResource();
=> Strings.GroupByDateCreatedDayDescription.GetLocalizedResource();
}

internal sealed partial class GroupByDateDeletedYearAction : GroupByDateAction
@@ -299,10 +299,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Year;

public override string Label
=> "Year".GetLocalizedResource();
=> Strings.Year.GetLocalizedResource();

public override string Description
=> "GroupByDateDeletedYearDescription".GetLocalizedResource();
=> Strings.GroupByDateDeletedYearDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.RecycleBin;
@@ -317,10 +317,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Month;

public override string Label
=> "Month".GetLocalizedResource();
=> Strings.Month.GetLocalizedResource();

public override string Description
=> "GroupByDateDeletedMonthDescription".GetLocalizedResource();
=> Strings.GroupByDateDeletedMonthDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.RecycleBin;
@@ -335,10 +335,10 @@ protected override GroupByDateUnit GroupByDateUnit
=> GroupByDateUnit.Day;

public override string Label
=> "Day".GetLocalizedResource();
=> Strings.Day.GetLocalizedResource();

public override string Description
=> "GroupByDateDeletedDayDescription".GetLocalizedResource();
=> Strings.GroupByDateDeletedDayDescription.GetLocalizedResource();

protected override bool GetIsExecutable(ContentPageTypes pageType)
=> pageType is ContentPageTypes.RecycleBin;
@@ -406,10 +406,10 @@ internal sealed partial class GroupAscendingAction : ObservableObject, IToggleAc
private readonly IDisplayPageContext context;

public string Label
=> "Ascending".GetLocalizedResource();
=> Strings.Ascending.GetLocalizedResource();

public string Description
=> "GroupAscendingDescription".GetLocalizedResource();
=> Strings.GroupAscendingDescription.GetLocalizedResource();

public bool IsOn
=> context.GroupDirection is SortDirection.Ascending;
@@ -451,10 +451,10 @@ internal sealed partial class GroupDescendingAction : ObservableObject, IToggleA
private readonly IDisplayPageContext context;

public string Label
=> "Descending".GetLocalizedResource();
=> Strings.Descending.GetLocalizedResource();

public string Description
=> "GroupDescendingDescription".GetLocalizedResource();
=> Strings.GroupDescendingDescription.GetLocalizedResource();

public bool IsOn
=> context.GroupDirection is SortDirection.Descending;
@@ -496,10 +496,10 @@ internal sealed class ToggleGroupDirectionAction : IAction
private readonly IDisplayPageContext context;

public string Label
=> "ToggleSortDirection".GetLocalizedResource();
=> Strings.ToggleSortDirection.GetLocalizedResource();

public string Description
=> "ToggleGroupDirectionDescription".GetLocalizedResource();
=> Strings.ToggleGroupDirectionDescription.GetLocalizedResource();

public ToggleGroupDirectionAction()
{
@@ -520,10 +520,10 @@ internal sealed partial class GroupByYearAction : ObservableObject, IToggleActio
private readonly IDisplayPageContext context;

public string Label
=> "Year".GetLocalizedResource();
=> Strings.Year.GetLocalizedResource();

public string Description
=> "GroupByYearDescription".GetLocalizedResource();
=> Strings.GroupByYearDescription.GetLocalizedResource();

public bool IsOn
=> context.GroupByDateUnit is GroupByDateUnit.Year;
@@ -565,10 +565,10 @@ internal sealed partial class GroupByMonthAction : ObservableObject, IToggleActi
private readonly IDisplayPageContext context;

public string Label
=> "Month".GetLocalizedResource();
=> Strings.Month.GetLocalizedResource();

public string Description
=> "GroupByMonthDescription".GetLocalizedResource();
=> Strings.GroupByMonthDescription.GetLocalizedResource();

public bool IsOn
=> context.GroupByDateUnit is GroupByDateUnit.Month;
@@ -610,10 +610,10 @@ internal sealed class ToggleGroupByDateUnitAction : IAction
private readonly IDisplayPageContext context;

public string Label
=> "ToggleGroupingUnit".GetLocalizedResource();
=> Strings.ToggleGroupingUnit.GetLocalizedResource();

public string Description
=> "ToggleGroupByDateUnitDescription".GetLocalizedResource();
=> Strings.ToggleGroupByDateUnitDescription.GetLocalizedResource();

public ToggleGroupByDateUnitAction()
{
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/PasteItemAction.cs
View file
Original file line number Diff line number Diff line change
@@ -16,10 +16,10 @@ internal sealed partial class PasteItemAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "Paste".GetLocalizedResource();
=> Strings.Paste.GetLocalizedResource();

public string Description
=> "PasteItemDescription".GetLocalizedResource();
=> Strings.PasteItemDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Paste");
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/PasteItemToSelectionAction.cs
View file
Original file line number Diff line number Diff line change
@@ -8,10 +8,10 @@ internal sealed partial class PasteItemToSelectionAction : BaseUIAction, IAction
private readonly IContentPageContext context;

public string Label
=> "Paste".GetLocalizedResource();
=> Strings.Paste.GetLocalizedResource();

public string Description
=> "PasteItemToSelectionDescription".GetLocalizedResource();
=> Strings.PasteItemToSelectionDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Paste");
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/RenameAction.cs
View file
Original file line number Diff line number Diff line change
@@ -8,10 +8,10 @@ internal sealed partial class RenameAction : ObservableObject, IAction
private readonly IContentPageContext context;

public string Label
=> "Rename".GetLocalizedResource();
=> Strings.Rename.GetLocalizedResource();

public string Description
=> "RenameDescription".GetLocalizedResource();
=> Strings.RenameDescription.GetLocalizedResource();

public HotKey HotKey
=> new(Keys.F2);
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/Transfer/CopyItemAction.cs
View file
Original file line number Diff line number Diff line change
@@ -8,10 +8,10 @@ namespace Files.App.Actions
internal sealed partial class CopyItemAction : BaseTransferItemAction, IAction
{
public string Label
=> "Copy".GetLocalizedResource();
=> Strings.Copy.GetLocalizedResource();

public string Description
=> "CopyItemDescription".GetLocalizedResource();
=> Strings.CopyItemDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Copy");
4 changes: 2 additions & 2 deletions src/Files.App/Actions/FileSystem/Transfer/CutItemAction.cs
View file
Original file line number Diff line number Diff line change
@@ -8,10 +8,10 @@ namespace Files.App.Actions
internal sealed partial class CutItemAction : BaseTransferItemAction, IAction
{
public string Label
=> "Cut".GetLocalizedResource();
=> Strings.Cut.GetLocalizedResource();

public string Description
=> "CutItemDescription".GetLocalizedResource();
=> Strings.CutItemDescription.GetLocalizedResource();

public RichGlyph Glyph
=> new(themedIconStyle: "App.ThemedIcons.Cut");
Loading
Oops, something went wrong.
Loading
Oops, something went wrong.