Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Implemented Breadcrumb #16946

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Code Quality: Implemented Breadcrumb #16946

merged 1 commit into from
Mar 23, 2025

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Mar 16, 2025 •
edited
Loading

Resolved / Related Issues

Steps used to test these changes

  1. Open Files UI tests app
  2. Go to Breadcrumb page
  3. Check the ellipsis behavior
  4. Check the flyout behavior
  5. Check the button click behavior
  6. Check the behavior when the window size changed
  7. Check the tabbing behavior (It only should XY navigation within the BreadcrumbBar)

Full:
image
With ellipsis:
image
Item chevron flyout:
image

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-BreadcrumbBar branch 9 times, most recently from 740511e to c21a8f3 Compare March 22, 2025 11:59
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-BreadcrumbBar branch from 8c55b4d to 2a05bc1 Compare March 22, 2025 17:05
@0x5bfa 0x5bfa marked this pull request as ready for review March 22, 2025 17:11
@yaira2 yaira2 merged commit c470854 into files-community:main Mar 23, 2025
6 checks passed
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 23, 2025
@0x5bfa 0x5bfa deleted the 5bfa/CQ-BreadcrumbBar branch March 23, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x5bfa @yaira2