Secret hiding base CI resource #5096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5096 +/- ##
======================================================
Coverage 83.14% 83.14%
======================================================
Files 248 248
Lines 26923 26923
======================================================
Hits 22386 22386
Misses 4537 4537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
37b9dcc to
3bca636
Compare
roypat
reviewed
Mar 19, 2025
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
dae2d55 to
451a7d2
Compare
roypat
reviewed
Mar 20, 2025
roypat
reviewed
Mar 20, 2025
|
|
||
| # Finally run olddefconfig again to make sure any | ||
| # new options are configured before build | ||
| make olddefconfig |
There was a problem hiding this comment.
Should we add some sort of assertion here to verify that .config contains everything we specify in kernel_config_overwrites? Just as a sanity check, to avoid ever running into any hard/weird to debug issues
JackThomson2
force-pushed
the
ci/kernel_installation
branch
6 times, most recently
from
070590a to
ffcab3f
Compare
roypat
reviewed
Mar 21, 2025
.buildkite/pipeline_pr.py
Outdated
| pipeline.build_group_per_arch( | ||
| "🕵️ Build Secret Hiding Kernel", | ||
| pipeline.devtool_test( | ||
| pytest_opts="-m nonci integration_tests/build/test_hiding_kernel.py", |
There was a problem hiding this comment.
mh, I guess as long as we don't setup an nightly pipelines, reusing nonci is fine, but if we ever have a nightly pipeline on this branch that also passes -m nonci, then it might pick up this test by accident, which we don't want probably. Thought on using a dedicated pytest mark for this test? :o
There was a problem hiding this comment.
Added a new secret_hiding mark for the test
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
ffcab3f to
c02988a
Compare
JackThomson2
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
c02988a to
cc851c5
Compare
Creating a script to build and install a modified kernel with patches applied. Signed-off-by: Jack Thomson <jackabt@amazon.com>
Update the script to allow it to run the build without installing. Allow us to add patches in different formats, we now allow .lore files which are a link to the patch series, these will be automatically downloaded and applied. We also accept .mbox files which again will be patched onto our kernel. Signed-off-by: Jack Thomson <jackabt@amazon.com>
Adding a new integration test to assert that the kernel build script will succeed. Signed-off-by: Jack Thomson <jackabt@amazon.com>
JackThomson2
force-pushed
the
ci/kernel_installation
branch
from
cc851c5 to
9a7c7e9
Compare
roypat
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding the base script to be used for building custom kernels with secret hiding patches applied for testing
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.