CI: Add RTJO tests for Go and Ruby #19079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d10c
added
the
Run: RTJO Language Tests
d10c
force-pushed
the
d10c/rtjo-language-tests
branch
from
1695705 to
34dc47a
Compare
d10c
added
Run: RTJO Language Tests
d10c
force-pushed
the
d10c/rtjo-language-tests
branch
2 times, most recently
from
ec86e0c to
f7804e6
Compare
d10c
added
Run: RTJO Language Tests
|
Triggering by adding the "Run: RTJO Language Tests" label works; blocked getting the engine to pass the tests under RTJO. |
d10c
added
Run: RTJO Language Tests
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new CI workflows to run language tests with run-time join ordering (RTJO) for both Ruby and Go. Key changes include:
- Adding a Ruby workflow (.github/workflows/ruby-qltest-rtjo.yml) to run QL tests with RTJO.
- Adding a Go workflow (.github/workflows/go-tests-rtjo.yml) to run tests with RTJO.
- Updating the Go test action (go/actions/test/action.yml) to accept a dynamic join order mode flag.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/ruby-qltest-rtjo.yml | New CI workflow for Ruby RTJO language tests. |
| .github/workflows/go-tests-rtjo.yml | New CI workflow for Go RTJO tests. |
| go/actions/test/action.yml | Updated action to pass dynamic join order mode to the Makefile. |
Files not reviewed (1)
- go/Makefile: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/ruby-qltest-rtjo.yml:24
- The runner label 'ubuntu-latest-xl' is non-standard; please ensure this is intentional and that the intended runner is available.
runs-on: ubuntu-latest-xl
.github/workflows/go-tests-rtjo.yml:14
- The runner label 'ubuntu-latest-xl' is non-standard; please verify that this label correctly references a configured runner in your environment.
runs-on: ubuntu-latest-xl
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
|
Because this is public it will get a nightly codeql so we need to wait until tomorrow before the fix to RTJO is available. |
d10c
force-pushed
the
d10c/rtjo-language-tests
branch
from
8bfe8fa to
428f221
Compare
alexet
approved these changes
Mar 25, 2025
d10c
added
Run: RTJO Language Tests
Triggered by adding "Run: RTJO Language Tests" label.
Triggered by adding label "Run: RTJO Language Tests"
d10c
force-pushed
the
d10c/rtjo-language-tests
branch
from
428f221 to
659eaf8
Compare
d10c
removed
the
Run: RTJO Language Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new QL language test CI jobs next to the existing ones in this repo, using run-time join ordering (
--dynamic-join-order-mode=all), to be triggered by adding the "Run: RTJO Language Tests" label.