Java: Adjust caching of BasicBlocks, BaseSSA, and CompileTimeConstants #19093
+62
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -24,7 +40,10 @@ | |||
|
|
|||
| /** Gets an immediate successor of this basic block. */ | |||
| cached | |||
| BasicBlock getABBSuccessor() { result = this.getLastNode().getASuccessor() } | |||
| BasicBlock getABBSuccessor() { | |||
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase. Warning
aschackmull
added
the
no-change-note-required
aschackmull
changed the title
|
Dca looks like a decent performance improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 3 changes to caching in the Java QL libs (separated cleanly in individual commits):
All 3 of these changes were motivated by statically inspecting DIL overlap between stages. These cases stood out as potentially being able to cause recomputation.
The changes caused a bit of performance fallout, which was fixed in an additional commit.