[spicedb] Fix intermittent "Error: 4 DEADLINE_EXCEEDED...Waiting for LB pick" #20637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
geropl
force-pushed
the
gpl/370-grpcjs
branch
2 times, most recently
from
560e4dc to
a2465ac
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
meta: stale
…5.0 -> 1.2.2 Tool: gitpod/catfood.gitpod.cloud
- instead of doing retries on two levels, rely on the gRPC-level retries - to mitigate the loss of insights, introduce createDebugLogInterceptor - client options: use sane defaults derived from the documentation instead of the excessive ones we had in place before - use "waitForReady" option: it should a) make our calls for responsive on re-connects, while b) - because we keep re-trying on DEADLINE_EXCEEDED - should be as reliable as before Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
…k" error Tool: gitpod/catfood.gitpod.cloud
|
This is ready to be merged now, see https://linear.app/gitpod/issue/CLC-370/grpcgrcp-js-deadline-exceeded-waiting-for-lb-pick#comment-7e018052 for details on how this has been tested and the results. |
corneliusludmann
approved these changes
Mar 17, 2025
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a fresh attempt at fixing the gRPC error
Error: 4 DEADLINE_EXCEEDED...Waiting for LB pickwe see every couple of weeks betweenserverandspicedb. This seems always be triggered by thespicedbpods restarting, while we have active/new requests coming in.Most likely it's fixed by bumping
grpc/grpc-js, as there were at couple of potential fixes between1.10.8and1.12.6[1, 2, 3, 4, ....].It turned out we still get the
Waiting for LB pick, where the client stalls for ~120s before connecting to upstream again, although the pod is up andReadyafter ~5-8s.To we are catching that specific case now, and re-trying the call with a fresh client.
Next steps:
load test in cluster (while manually tearing downspicedbRelated Issue(s)
Fixes CLC-370
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold