[server] Introduces ReadinessProbe #20669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool: gitpod/catfood.gitpod.cloud
…d port Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
…sable the ReadinessProbe if required Tool: gitpod/catfood.gitpod.cloud
- Add PRD workflow to systemPatterns.md as a standardized development process - Update .clinerules with instructions to follow the PRD workflow - Update activeContext.md and progress.md to reference the new workflow This formalizes the process we used for implementing the server readiness probe feature. Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
github-actions
bot
added
team: team-experience
team: team-enterprise
and removed
size/XL
labels
iQQBot
reviewed
Mar 17, 2025
iQQBot
reviewed
Mar 17, 2025
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
iQQBot
approved these changes
Mar 17, 2025
|
I haven't run test yet, did you run any test? @geropl |
Yes, the manual one's mentioned above 👍 Just waiting for the build to pass - not sure why it's different than local |
It's same, but I don't know the preview URL ... |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We never had a ReadinessProbe in
server- until now.Why? To avoid error spikes during rollouts, when requests hit server instances but they are not "Ready", yet.
More specifically, this is about authorization issues when
serverinstances haven't successfully connected tospicedb, yet (see CLC-1230 for details).To mitigate any unforeseen operations cases where this blocks us, this is guarded by a feature flag called
server_readiness_probeRelated Issue(s)
Fixes CLC-1230
How to test
watch kubectl get podskubectl scale --replicas=8 deployment/serverkubectl scale --replicas=3 deployment/serverDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold