-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jpms: add 'require static' entries for annotation processing #7732
jpms: add 'require static' entries for annotation processing #7732
Conversation
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
Hi, again, and thanks. I agree that the lack of a I left some notes in jspecify/jspecify#495 (comment). |
This fixes warnings that arise when javac goes looking for, e.g., `DoNotMock.value()`, which it can't find if the Guava module is not permitted to access `error_prone_annotations`. The warnings don't come up with JSpecify annotations (or perhaps J2ObjC annotations?), but it seems reasonable to declare those dependencies, too: If we were building Guava as a "normal" module (instead of [building its `module-info` separately](https://github.com/google/guava/blob/6dcc4ef29811962cfbcdbc888a0dc9c4a1efc1a3/guava/pom.xml#L101-L141)), javac would _force_ us to declare them. Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> Fixes #7732 RELNOTES=Fixed annotation-related warnings when using Guava in modular builds. The most common such warning is `Cannot find annotation method 'value()' in type 'DoNotMock': ...`. PiperOrigin-RevId: 740339488
This fixes warnings that arise when javac goes looking for, e.g., `DoNotMock.value()`, which it can't find if the Guava module is not permitted to access `error_prone_annotations`. The warnings don't come up with JSpecify annotations (or perhaps J2ObjC annotations?), but it seems reasonable to declare those dependencies, too: If we were building Guava as a "normal" module (instead of [building its `module-info` separately](https://github.com/google/guava/blob/6dcc4ef29811962cfbcdbc888a0dc9c4a1efc1a3/guava/pom.xml#L101-L141)), javac would _force_ us to declare them. Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> Fixes #7732 RELNOTES=Fixed annotation-related warnings when using Guava in modular builds. The most common such warning is `Cannot find annotation method 'value()' in type 'DoNotMock': ...`. PiperOrigin-RevId: 740339488
This fixes warnings that arise when javac goes looking for, e.g., `DoNotMock.value()`, which it can't find if the Guava module is not permitted to access `error_prone_annotations`. The warnings don't come up with JSpecify annotations (or perhaps J2ObjC annotations?), but it seems reasonable to declare those dependencies, too: If we were building Guava as a "normal" module (instead of [building its `module-info` separately](https://github.com/google/guava/blob/6dcc4ef29811962cfbcdbc888a0dc9c4a1efc1a3/guava/pom.xml#L101-L141)), javac would _force_ us to declare them. Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> Fixes #7732 RELNOTES=Fixed annotation-related warnings when using Guava in modular builds. The most common such warning is `Cannot find annotation method 'value()' in type 'DoNotMock': ...`. PiperOrigin-RevId: 740355816
Follow up to: #2970
The annotation libraries that provide annotations used on public API should be declared as
require static
. Otherwise, compiling with-Xlint:all
and-Werror
fails because all annotations that are visited need to be accessible from the context of the module they are used in.Example error:
https://scans.gradle.com/s/ose6lkdbtogww/console-log/task/:hedera-protobuf-java-api:compileJava?anchor=5&page=1
For more details see also this similar issue in Log4j2: apache/logging-log4j2#3437
I believe Guava's own build would fail without this at compilation time if annotation processing would be done on the module path (
--process-module-path
).Unfortunately, that's a bit complex to configure currently: https://issues.apache.org/jira/browse/MCOMPILER-412