Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy private data sources in batches #5907

Merged
merged 5 commits into from
Mar 28, 2025
Merged

Copy private data sources in batches #5907

merged 5 commits into from
Mar 28, 2025

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented Mar 25, 2025

Currently, private data sources are copied one-by-one which can be very slow for deployments with huge numbers of data sources (say, 100's of thousands)

This PR changes that so that we copy data sources in bulk

@lutter lutter requested a review from zorancv March 25, 2025 01:15
Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly solid, with some minor remarks.

Copy link
Contributor

@zorancv zorancv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lutter lutter merged commit 776afa1 into master Mar 28, 2025
6 checks passed
@lutter lutter deleted the lutter/copy-ds branch March 28, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants