HHH-19247 Add ordinal() to TypeContributor #9865
Closed
+107
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbladel
requested changes
Mar 24, 2025
hibernate-core/src/main/java/org/hibernate/boot/model/Ordinated.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/process/spi/MetadataBuildingProcess.java
Outdated
Show resolved
Hide resolved
mbladel
reviewed
Mar 26, 2025
There was a problem hiding this comment.
@kad-barens much better. Only one last whitespace change to revert.
Lastly, we implement improvements like this on the main branch, not on current stable versions, so please switch this PR to that and squash all change to a single commit please.
hibernate-core/src/main/java/org/hibernate/boot/model/FunctionContributor.java
Outdated
Show resolved
Hide resolved
…uence the order in which serviceloaded custom types are registered
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
|
Looks like changing the base doesn't work nicely on the GitHub web UI. Can you please cherry-pick this commit on top of the |
|
I noticed that too, I'm already working on a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FunctionContributor already has an ordinal() method to be able to influence the order in which function contributions are loaded.
The same mechanism would be helpful for Type contributions.
In our specific use case we need to override the SDOGeometryType, contributed by Hibernate Spatial, with our own custom type, for handling complex arcs.
In Hibernate 5 this worked well with a custom dialect, but with Hibernate 6 it is not possible anymore to override previously added types during service loading by changing the order in which they are loaded.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19247