Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double incrementing te_request_count metric #486

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

kozistr
Copy link
Contributor

@kozistr kozistr commented Feb 6, 2025

What does this PR do?

Fixes #480

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@OlivierDehaene OR @Narsil

Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe cc @Narsil for visibility too!

@alvarobartt alvarobartt requested a review from Narsil March 5, 2025 16:41
@vrdn-23
Copy link

vrdn-23 commented Mar 13, 2025

Can this be merged if there aren't any pending changes? @alvarobartt

@alvarobartt alvarobartt merged commit f0bf723 into huggingface:main Mar 24, 2025
@kozistr kozistr deleted the fix/metric branch March 24, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug report] Double incrementing te_request_count metric in successful single openai_embed requests
3 participants