Add update_g_idx flag for setting qweight&g_idx
#2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
Kaihui-intel
changed the title
update_g_idx flag for setting qweight&g_idx
Kaihui-intel
added
the
related to ipex-xpu v2.7
|
I saw IPEX PR has been merged. have we validated it? We do not need to wait for IPEX-XPU v2.7. If there is issue, we need to raise before their release. |
thuang6
reviewed
Mar 17, 2025
Signed-off-by: Kaihui-intel <kaihui.tang@intel.com>
for more information, see https://pre-commit.ci
XuehaoSun
approved these changes
Mar 21, 2025
thuang6
reviewed
Mar 24, 2025
| module.qweight.data if hasattr(module, "qweight") else weight, | ||
| None if module.bias is None else module.bias.data, | ||
| ) | ||
| if ipex_version >= Version("2.7"): |
There was a problem hiding this comment.
is it possible to check interface itself support this arg instead of chekc IPEX version directly? current approach looks not very robust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
bug fix
Description
add
update_g_idxflag to avoid secondary value updates.note:
waiting for the release of ipex-gpu v2.7 ...
related PR: https://github.com/intel-innersource/frameworks.ai.pytorch.ipex-gpu/pull/5411
results:
meta-llama/Meta-Llama-3-8B-Instruct on PVC
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed