Dots in local part of emails not handled properly - fix #322

Author: bshannon

doc/release/CHANGES.txt

@@ -28,6 +28,7 @@ GH  315	empty Content-Transfer-Encoding header causes IOException
 GH  316	starttls.enable documentation should reference starttls.required prop
 GH  317	use System.lineSeparator() instead of System.getProperty(...)
 GH  321	URLName.getURL() returns incorrect url.
+GH  322	Dots in local part of emails not handled properly
 
 
 		  CHANGES IN THE 1.6.1 RELEASE

mail/src/main/java/javax/mail/internet/InternetAddress.java

@@ -1343,12 +1343,22 @@ private static void checkAddress(String addr,
 		    throw new AddressException(
 		     "Quoted local address contains newline without whitespace",
 			addr);
+	    } else if (c == '.') {
+		if (i == start)
+		    throw new AddressException(
+			"Local address starts with dot", addr);
+		if (lastc == '.')
+		    throw new AddressException(
+			"Local address contains dot-dot", addr);
 	    }
 	    if (inquote)
 		continue;
 	    if (c == '@') {
 		if (i == 0)
 		    throw new AddressException("Missing local name", addr);
+		if (lastc == '.')
+		    throw new AddressException(
+			"Local address ends with dot", addr);
 		break;		// done with local part
 	    }
 	    if (c <= 040 || c == 0177)

mail/src/test/resources/javax/mail/internet/addrlist

@@ -395,6 +395,12 @@ To: a@com.
 Expect: Exception javax.mail.internet.AddressException: Domain ends with dot in string ``a@com.''
 To: a@b..com
 Expect: Exception javax.mail.internet.AddressException: Domain contains dot-dot in string ``a@b..com''
+To: .a@b.com
+Expect: Exception javax.mail.internet.AddressException: Local address starts with dot in string ``.a@b.com''
+To: a.@b.com
+Expect: Exception javax.mail.internet.AddressException: Local address ends with dot in string ``a.@b.com''
+To: a..b@b.com
+Expect: Exception javax.mail.internet.AddressException: Local address contains dot-dot in string ``a..b@b.com''
 To: a@
com
 Expect: Exception javax.mail.internet.AddressException: Domain contains control or whitespace in string ``a@
com''
 To: a
@b.com