Fix Issue 1251: covariance calc for insufficient data points #1253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1251
The code was generating runtime warnings when calculating covariance with insufficient data points:
RuntimeWarning: Degrees of freedom <= 0 for slice
cov_matrix = np.cov(equity_log_returns, market_log_returns)
Added length checks before covariance calculation to handle cases where:
The fix returns
np.nan
for both Alpha and Beta metrics when there isn't enough data for a valid covariance calculation.