libhns: Cleanup and Bugfixes #1579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up mixed signed/unsigned type issues. Fix a wrong format character as well. Fixes: cf6d914 ("libhns: Introduce hns direct verbs") Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
When cap.max_inline_data is 0, it will be modified to 1 since roundup_pow_of_two(0) == 1, which violates users' expectations. Here fix it. Fixes: 2aff0d5 ("libhns: Fix the problem of sge nums") Signed-off-by: wenglianfa <wenglianfa@huawei.com> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
The spin_unlock order should be the reverse of spin_lock order. Fixes: 179f015 ("libhns: Add support for lock-free QP") Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
rleon
reviewed
Mar 13, 2025
| @@ -1307,9 +1317,7 @@ static void set_ext_sge_param(struct hns_roce_context *ctx, | |||
| attr->cap.max_send_sge); | |||
|
|
|||
| if (ctx->config & HNS_ROCE_RSP_EXSGE_FLAGS) { | |||
| attr->cap.max_inline_data = min_t(uint32_t, roundup_pow_of_two( | |||
There was a problem hiding this comment.
Just use min3() instead.
Sorry I don't get it. Only two values are compared here
There was a problem hiding this comment.
min3(attr->cap.max_inline_data, roundup_pow_of_two(attr->cap.max_inline_data), ctx->max_inline_data)
There was a problem hiding this comment.
min3(attr->cap.max_inline_data, roundup_pow_of_two(attr->cap.max_inline_data), ctx->max_inline_data)
This is wrong when attr->cap.max_inline_data is not power of 2
There was a problem hiding this comment.
I tried, but the result was really not what we expected, since roundup_pow_of_two(attr->cap.max_inline_data) will never be smaller than attr->cap.max_inline_data. What we want is the roundup_pow_of_two() value.
attr->cap.max_inline_data = 3
roundup_pow_of_two(attr->cap.max_inline_data) = 4
ctx->max_inline_data = 1024
min3 result = 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some recent cleanup and bugfixes for libhns.