Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add Time-Only Column Type to the Table Component #1553

Merged
merged 8 commits into from
Mar 11, 2025

Conversation

iamfaran
Copy link
Collaborator

@iamfaran iamfaran commented Mar 1, 2025

Proposed changes

This feature adds a "Time-only" column type to the Table component, ensuring users can input only time values. It was built using the existing DateTime component and reuses the suffix/prefix icon from SimpleTextComp

Types of changes

What types of changes does your code introduce to Lowcoder?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

dependabot bot and others added 5 commits February 4, 2025 14:50
Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.13.33 to 3.22.0.
- [Release notes](https://github.com/snowflakedb/snowflake-jdbc/releases)
- [Changelog](https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst)
- [Commits](snowflakedb/snowflake-jdbc@v3.13.33...v3.22.0)

---
updated-dependencies:
- dependency-name: net.snowflake:snowflake-jdbc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
…-plugins/snowflakePlugin/net.snowflake-snowflake-jdbc-3.22.0
…en/server/api-service/lowcoder-plugins/snowflakePlugin/net.snowflake-snowflake-jdbc-3.22.0

Bump net.snowflake:snowflake-jdbc from 3.13.33 to 3.22.0 in /server/api-service/lowcoder-plugins/snowflakePlugin
Copy link

netlify bot commented Mar 1, 2025

👷 Deploy request for lowcoder-cloud pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8a100b5

@raheeliftikhar5 raheeliftikhar5 self-requested a review March 3, 2025 10:30
@raheeliftikhar5
Copy link
Collaborator

raheeliftikhar5 commented Mar 3, 2025

Hey Faran, following are the issues i found in your PR:

  1. When we select column type "Time" and there is no column value, it should show empty text in table instead of default date.
Screenshot 2025-03-03 at 15 36 04
  1. When we make this "Time" column editable and user try to edit by double clicking, it should show only time picker instead of data and time picker. Kindly check Ant design's data picker to see what props should we pass to show only time picker https://ant.design/components/date-picker
Screenshot 2025-03-03 at 15 37 50
  1. When i select value from current data/time picker, it should show the value in the column but it shows empty.
Screenshot 2025-03-03 at 15 42 53

Please check these issues, and let me know if there is any question. Thanks

Copy link
Collaborator

@raheeliftikhar5 raheeliftikhar5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments.

@FalkWolsky FalkWolsky changed the base branch from main to dev March 3, 2025 13:40
Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for lowcoder-test failed.

Name Link
🔨 Latest commit 2888b68
🔍 Latest deploy log https://app.netlify.com/sites/lowcoder-test/deploys/67d003b705bc770008f8cba6

@iamfaran
Copy link
Collaborator Author

iamfaran commented Mar 3, 2025

@raheeliftikhar5 I have addressed the requested changes. Please review again when you have time. Thanks!

@raheeliftikhar5 raheeliftikhar5 changed the title [Feat]: Add Time-Only Column Type to the Table Component (#1549) [Feat]: Add Time-Only Column Type to the Table Component Mar 3, 2025
@raheeliftikhar5 raheeliftikhar5 self-requested a review March 11, 2025 09:35
@raheeliftikhar5 raheeliftikhar5 merged commit 255d870 into lowcoder-org:dev Mar 11, 2025
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants