-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Add Time-Only Column Type to the Table Component #1553
Conversation
Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.13.33 to 3.22.0. - [Release notes](https://github.com/snowflakedb/snowflake-jdbc/releases) - [Changelog](https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst) - [Commits](snowflakedb/snowflake-jdbc@v3.13.33...v3.22.0) --- updated-dependencies: - dependency-name: net.snowflake:snowflake-jdbc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…-plugins/snowflakePlugin/net.snowflake-snowflake-jdbc-3.22.0
…en/server/api-service/lowcoder-plugins/snowflakePlugin/net.snowflake-snowflake-jdbc-3.22.0 Bump net.snowflake:snowflake-jdbc from 3.13.33 to 3.22.0 in /server/api-service/lowcoder-plugins/snowflakePlugin
👷 Deploy request for lowcoder-cloud pending review.Visit the deploys page to approve it
|
Hey Faran, following are the issues i found in your PR:
![]()
![]()
![]() Please check these issues, and let me know if there is any question. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check comments.
❌ Deploy Preview for lowcoder-test failed.
|
@raheeliftikhar5 I have addressed the requested changes. Please review again when you have time. Thanks! |
Proposed changes
This feature adds a "Time-only" column type to the Table component, ensuring users can input only time values. It was built using the existing DateTime component and reuses the suffix/prefix icon from SimpleTextComp
Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
x
in the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
x
in the boxes that apply.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.