-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTPYTHON-549 Rework the projection logic to allow reading list-of-struct data structures using a specified schema #285
Conversation
Thank you @zpks! Can you please add a test that covers your reported bug to |
It looks like this introduced some other failures. Are you able to run the test suite locally? |
Hello! Thank you for looking, and my apologies for creating the PR prematurely After some wrangling I was able to test locally. The change I made changes the projections from {"struct_col": {"field_1": True, "field_2": True}} to {"struct_col.field_1": True, "struct_col.field_2": True} - this works better with the mongo driver, as mongo interperts the dot as separating struct and field - and this also works for list-of-struct structures. There was still an unrelated test failing TestExplicitPolarsApi.test_exceptions_for_unsupported_polar_types |
interestingly enough my local ruff ran fine, but the github version finds a too-long line |
If you merge from |
We have instructions for running the linters locally, or in this case you can copy-paste the affected lines from the diff. |
I installed and initialized pre-commit, it ran all it's steps and passed - but I'll run it with tox too |
Okay I rebased on main (I had to sync my fork first - again, my apology for the mess) and explicityly ran the linter, that fixed the issue - I suppose I had only installed pre-commit after the too-long line was committed. Thank you for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
see #284