CDRIVER-5514 drop support for Cyrus-SASL on Windows #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector-of-bool
approved these changes
Mar 18, 2025
| @@ -23,6 +23,8 @@ Unreleased (2.0.0) | |||
| * `mongoc_cursor_is_alive` is removed. Use the equivalent `mongoc_cursor_more` instead. | |||
| * `mongoc_collection_delete` is removed. Use `mongoc_collection_delete_one` or `mongoc_collection_delete_many` instead. | |||
| * `mongoc_delete_flags_t` and `mongoc_reply_flags_t` are removed. | |||
| * Support for `ENABLE_SASL=CYRUS` on Windows is removed. Use `ENABLE_SASL=SSPI` or `ENABLE_SASL=OFF` instead. | |||
There was a problem hiding this comment.
Is there a need to support disabling SASL on Windows if SSPI ships with Windows?
There was a problem hiding this comment.
I am not sure if there is a compelling use-case, but it could be used to avoid linking to unnecessary Windows DLLs (e.g. with ENABLE_SASL=OFF and ENABLE_SSL=OFF, I see SECURE32.DLL, CRYPT32.DLL, and BCRYPT.DLL are no longer shown in Dependency Walker.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_SASL=CYRUSon WindowsCYRUS_PLUGIN_PATH_PREFIX.Background & Motivation
See CDRIVER-5696. Cyrus-SASL on Windows was untested and has little expected use.