CDRIVER-629 remove MONGOC_WRITE_CONCERN_W_ERRORS_IGNORED
#1940
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
MONGOC_WRITE_CONCERN_W_ERRORS_IGNORED
(-1) value, which is equivalent toMONGOC_WRITE_CONCERN_W_UNACKNOWLEDGED
(0).Notes
I was surprised to discover
mongoc_write_concern_is_valid
returns true for unsupported values ofw
. This PR does not change this behavior. The server returns an error for a negativew
value:Adding a client-side error might go against the Where possible, depend on server to return errors mantra.