Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDRIVER-5935 remove deprecated bson_copy_to_excluding #1946

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

kevinAlbs
Copy link
Collaborator

No description provided.

@kevinAlbs kevinAlbs changed the title remove deprecated bson_copy_to_excluding CDRIVER-5935 remove deprecated bson_copy_to_excluding Mar 24, 2025
@kevinAlbs kevinAlbs marked this pull request as ready for review March 24, 2025 12:31
Copy link
Collaborator

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Wondering if adopting something like documentation-only attributes may be useful for differentiating pointer-to-storage parameters.

@kevinAlbs
Copy link
Collaborator Author

Wondering if adopting something like documentation-only attributes may be useful for differentiating pointer-to-storage parameters.

I support that idea. I expect an attribute could help consistently document NULL-able parameters too.

@kevinAlbs kevinAlbs merged commit 6f9e482 into mongodb:master Mar 25, 2025
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants