GODRIVER-3451 Add fuzz test for BSON MarshalValue/UnmarshalValue. #1993
+79
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
|
@matthewdale Can you re-configure the evergreen tasks to include Fuzz testing? |
prestonvasquez
requested changes
Mar 26, 2025
| // int64, including max and min values. | ||
| int64(0), math.MaxInt64, math.MinInt64, | ||
| // string, including empty and large string. | ||
| "", strings.Repeat("z", 10_000), |
There was a problem hiding this comment.
Should we extend this to include a nested structure and a slice?
map[string]any{"nested": []any{1, "two", map[string]any{"three", 3}}}
[]any{1, 2,3, "four"}
| f.Add(byte(typ), b) | ||
| } | ||
|
|
||
| f.Fuzz(func(t *testing.T, bsonType byte, data []byte) { |
There was a problem hiding this comment.
AFAIK we can run these tests in parallel.
| t.Fatalf("failed to marshal: %v", err) | ||
| } | ||
|
|
||
| if err := UnmarshalValue(typ, encoded, &v); err != nil { |
There was a problem hiding this comment.
Suggest decoding into a new value (e.g. var v2 any). Then we can compare the original value and the re-unmarshaled value to ensure roundtrip consistency:
if !reflect.DeepEqual(v, v2) {
t.Fatal("roundtrip mismatch: ...")
}| // to "nil". It's not clear if MarshalValue should support "nil", but | ||
| // for now we skip it. | ||
| if v == nil { | ||
| return |
There was a problem hiding this comment.
It might be worth logging such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3451
Summary
bson.MarshalValueandbson.UnmarshalValue.Background & Motivation