Updated netbox_circuit_termination.py to support NetBox 4.2.x

[nsthompson]

Related Issue

#1401

New Behavior

This fix is to resolve the changes created by the NetBox 4.2.0 release relating to:

The site and provider_network foreign key fields on circuits.CircuitTermination have been replaced by the termination generic foreign key.

Contrast to Current Behavior

Current behavior results in module failure with the error:

A circuit termination must attach to a terminating object.

Discussion: Benefits and Drawbacks

This fix resolves the issue with NetBox 4.2.x. It is backward compatible with prior versions.

Changes to the Documentation

Documentation in the module has been updated.

Proposed Release Note Entry

Updated netbox_circuit_termination.py to support NetBox 4.2.x breaking changes.

Double Check

• [ x ] I have read the comments and followed the CONTRIBUTING.md.
• [ x ] I have explained my PR according to the information in the comments or in a linked issue.
• [ x ] My PR targets the devel branch.

[sc68cal]

This needs to be done in a way that preserves backwards compatibility with older NetBox versions since we still use those for CI tests, and we have by convention supported the two most recent releases, which at this point would be 4.2 and 4.1

[nsthompson]

This needs to be done in a way that preserves backwards compatibility with older NetBox versions since we still use those for CI tests, and we have by convention supported the two most recent releases, which at this point would be 4.2 and 4.1

Thanks for the feedback, @sc68cal. I just pushed new changes that preserve backward compatibility and prevent parameter overlap between the params required for versions pre-4.2.0 and those for versions 4.2.0 and later.

The fix was tested against NetBox Cloud running 4.1.11 as well as 4.2.5.

[sc68cal]

Looks good, just some small style changes for black to be happy, and then a changelog fragment and then I think this is good to go

[sc68cal]

Doc build failure appears unrelated to your changes.