Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N1C certificates UI. Include screenshot. #259

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

N1C certificates UI. Include screenshot. #259

wants to merge 2 commits into from

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Mar 5, 2025 •
edited
Loading

Proposed changes

Include a screenshot to clarify the options associated with Certificates in NGINX One Console. Discussed internally with al.dacosta@f5.com

Review in this build: https://frontdoor-test-docs.nginx.com/previews/docs/259/nginx-one/how-to/nginx-configs/add-file/

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang self-assigned this Mar 5, 2025
@mjang mjang added documentation Improvements or additions to documentation customer-feedback product/nginx-one NGINX One Console labels Mar 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/259/

@mjang @ADubhlaoich
Update content/nginx-one/how-to/nginx-configs/add-file.md
58ea244 
Co-authored-by: Alan Dooley <a.dooley@f5.com>
@mjang mjang marked this pull request as ready for review March 5, 2025 17:37
@mjang mjang requested a review from a team as a code owner March 5, 2025 17:37
travisamartin
travisamartin reviewed Mar 5, 2025
View reviewed changes
content/nginx-one/how-to/nginx-configs/add-file.md
@@ -44,6 +44,8 @@ You can use the NGINX One Console to add a file to a specific instance. To do so

You now have multiple options, described in the sections which follow.

{{< img src="nginx-one/images/add-file-to-config.png" alt="A modal window to edit configuration, with a 'New Configuration File' option selected." >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a bulleted list of the options instead of a screenshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich

@travisamartin travisamartin

At least 2 approving reviews are required to merge this pull request.

Assignees

@mjang mjang

Labels
customer-feedback documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjang @ADubhlaoich @travisamartin