Skip to content

Commit 3a4d6ae

Browse files
committed
style: fixing more linting issues
1 parent f7c2ce7 commit 3a4d6ae

File tree

3 files changed

+25
-30
lines changed

3 files changed

+25
-30
lines changed

Diff for: plugins/node/opentelemetry-plugin-dns/test/integrations/dnspromise-lookup.test.ts

+23-29
Original file line numberDiff line numberDiff line change
@@ -33,23 +33,24 @@ const logger = new NoopLogger();
3333
const provider = new NodeTracerProvider({ logger });
3434
provider.addSpanProcessor(new SimpleSpanProcessor(memoryExporter));
3535

36-
async function lookupPromise(hostname:string, options:dns.LookupOptions = {}): Promise<any>{
36+
async function lookupPromise(
37+
hostname: string,
38+
options: dns.LookupOptions = {}
39+
): Promise<any> {
3740
return new Promise((resolve, reject) => {
38-
dns.lookup(hostname, options,(err, address, family) => {
39-
if(err) reject(err);
40-
if (options.all){
41-
resolve(address);
42-
}
43-
else{
44-
resolve({ address, family });
45-
}
46-
});
47-
});
48-
};
41+
dns.lookup(hostname, options, (err, address, family) => {
42+
if (err) reject(err);
43+
if (options.all) {
44+
resolve(address);
45+
} else {
46+
resolve({ address, family });
47+
}
48+
});
49+
});
50+
}
4951

5052
describe('dns.promises.lookup()', () => {
5153
before(function (done) {
52-
5354
// if node version is supported, it's mandatory for CI
5455
if (process.env.CI) {
5556
plugin.enable(dns, provider, provider.logger);
@@ -79,10 +80,9 @@ describe('dns.promises.lookup()', () => {
7980
[4, 6].forEach(ipversion => {
8081
it(`should export a valid span with "family" arg to ${ipversion}`, async () => {
8182
const hostname = 'google.com';
82-
const {address, family} = await lookupPromise(
83-
hostname,
84-
{family:ipversion}
85-
);
83+
const { address, family } = await lookupPromise(hostname, {
84+
family: ipversion,
85+
});
8686
assert.ok(address);
8787
assert.ok(family);
8888

@@ -97,9 +97,7 @@ describe('dns.promises.lookup()', () => {
9797
describe('with no options param', () => {
9898
it('should export a valid span', async () => {
9999
const hostname = 'google.com';
100-
const { address, family } = await lookupPromise(
101-
hostname
102-
);
100+
const { address, family } = await lookupPromise(hostname);
103101

104102
assert.ok(address);
105103
assert.ok(family);
@@ -113,9 +111,7 @@ describe('dns.promises.lookup()', () => {
113111
it('should export a valid span with error NOT_FOUND', async () => {
114112
const hostname = 'ᚕ';
115113
try {
116-
await lookupPromise(
117-
hostname
118-
);
114+
await lookupPromise(hostname);
119115
assert.fail();
120116
} catch (error) {
121117
const spans = memoryExporter.getFinishedSpans();
@@ -136,7 +132,7 @@ describe('dns.promises.lookup()', () => {
136132
it('should export a valid span with error INVALID_ARGUMENT when "family" param is equal to -1', async () => {
137133
const hostname = 'google.com';
138134
try {
139-
await lookupPromise(hostname, {family: -1});
135+
await lookupPromise(hostname, { family: -1 });
140136
assert.fail();
141137
} catch (error) {
142138
const spans = memoryExporter.getFinishedSpans();
@@ -153,8 +149,7 @@ describe('dns.promises.lookup()', () => {
153149
message: error!.message,
154150
},
155151
});
156-
}
157-
else{
152+
} else {
158153
assertSpan(span, {
159154
addresses: [],
160155
// tslint:disable-next-line:no-any
@@ -172,7 +167,7 @@ describe('dns.promises.lookup()', () => {
172167
const hostname = 1234;
173168
try {
174169
// tslint:disable-next-line:no-any
175-
await lookupPromise(hostname as any, {family: 4});
170+
await lookupPromise(hostname as any, { family: 4 });
176171
assert.fail();
177172
} catch (error) {
178173
const spans = memoryExporter.getFinishedSpans();
@@ -189,8 +184,7 @@ describe('dns.promises.lookup()', () => {
189184
message: error!.message,
190185
},
191186
});
192-
}
193-
else{
187+
} else {
194188
assertSpan(span, {
195189
addresses: [],
196190
// tslint:disable-next-line:no-any

Diff for: plugins/web/opentelemetry-plugin-user-interaction/test/helper.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export function assertClickSpan(span: tracing.ReadableSpan, id = 'testBtn') {
5858
}
5959

6060
export function getData(url: string, callbackAfterSend: Function) {
61-
return new Promise(async (resolve, reject) => {
61+
return new Promise((resolve, reject) => {
6262
const req = new XMLHttpRequest();
6363
req.open('GET', url, true);
6464
req.send();

Diff for: propagators/opentelemetry-propagator-grpc-census-binary/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"access": "public"
4343
},
4444
"devDependencies": {
45+
"@opentelemetry/context-base": "^0.9.0",
4546
"@types/mocha": "7.0.2",
4647
"@types/node": "12.12.47",
4748
"codecov": "3.7.0",

0 commit comments

Comments
 (0)