Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer Return Type for select from useInfiniteQuery #2169

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

awmichel
Copy link

Changes

Updates the types for useInfiniteQuery to infer the return type from the select option, if provided. Adds onto #2105 with recent addition of #2117.

Also adds the docs for useInfiniteQuery to the navigation in the docs site, it wasn't being linked to, and adds a note about customizing the query param name for pagination.

How to Review

See previous PR for the type inference in #2105 and additional test added to the useInfiniteQuery suite to check the return type is correctly inferred and functionally sound from useInfiniteQuery.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@awmichel awmichel requested a review from a team as a code owner February 24, 2025 23:25
@awmichel awmichel requested a review from htunnicliff February 24, 2025 23:25
Copy link

netlify bot commented Feb 24, 2025

👷 Deploy request for openapi-ts pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 78225d2

Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 78225d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-react-query Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@htunnicliff htunnicliff removed their request for review February 24, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant