Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core)!: update GRPC Gateway to use IPC #2005

Merged
merged 7 commits into from
Mar 28, 2025

Conversation

jrschumacher
Copy link
Member

@jrschumacher jrschumacher commented Mar 25, 2025

Closes #2004
DSPX-593

Proposed Changes

  • Bind GRPCGateway to the ConnectRPC IPC connection

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

CleanShot 2025-03-25 at 18 21 38

@jrschumacher jrschumacher requested review from a team as code owners March 25, 2025 22:54
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggstion would be to call this fix(core)!, as it introduces a breaking change to the gateway function. I think this will cause the version number for service to tick over to 0.5.0

@jrschumacher
Copy link
Member Author

That's fine by me but I didn't realize the breaking change would tick the minor. I thought it would bump the major.

@jrschumacher jrschumacher changed the title fix(core): update GRPC Gateway to use IPC fix(core)!: update GRPC Gateway to use IPC Mar 28, 2025
@jrschumacher jrschumacher added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit ff605f4 Mar 28, 2025
23 checks passed
@jrschumacher jrschumacher deleted the iss2004-fix-grpcgateway-loopback-call branch March 28, 2025 20:27
github-merge-queue bot pushed a commit that referenced this pull request Mar 28, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.5.0](service/v0.4.40...service/v0.5.0)
(2025-03-28)


### ⚠ BREAKING CHANGES

* **core:** update GRPC Gateway to use IPC
([#2005](#2005))
* **core:** Require go 1.23+
([#1979](#1979))

### Features

* **core:** Require go 1.23+
([#1979](#1979))
([164c922](164c922))


### Bug Fixes

* **core:** update GRPC Gateway to use IPC
([#2005](#2005))
([ff605f4](ff605f4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace GRPCGateway loopback call with IPC call
3 participants