Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/edit tutorial #23

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Review/edit tutorial #23

merged 4 commits into from
Mar 4, 2025

Conversation

rosemarymarano
Copy link
Contributor

Add it to the README

Add it to the README
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 4, 2025
junior
junior previously approved these changes Mar 4, 2025
@@ -42,17 +42,18 @@ Pull the WebLogic Server 14.1.2 image from the Oracle Container Registry:
docker pull docker pull container-registry.oracle.com/middleware/weblogic:14.1.2.0-generic-jdk21-ol9
```

> Note: This image is the base image running with JDK 21 on Oracle Linux 9. You can use any variant of the image that suits your environment or tests.
> [!NOTE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated to use the github notes type

@@ -64,13 +65,14 @@ Pull the WebLogic Server 14.1.2 image from the Oracle Container Registry:
podman pull docker pull container-registry.oracle.com/middleware/weblogic:14.1.2.0-generic-jdk21-ol9
```

> Note: This image is the base image running with JDK 21 on Oracle Linux 9. You can use any variant of the image that suits your environment or tests.
> [!NOTE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated to use the github notes type

@@ -84,8 +86,9 @@ EOF
docker run --rm -it -p 9002:9002 -p 7001:7001 --name wlsadmin --hostname wlsadmin -v ./domain.properties:/u01/oracle/properties/domain.properties container-registry.oracle.com/middleware/weblogic:14.1.2.0-generic-jdk21-ol9
```

> Note: This command runs the WebLogic Server 14.1.2 container with the admin server running on port 7001 and the management console running on port 9002. The domain properties file is mounted to the container to set the username and password for the WebLogic Server admin console.
> Change the username and password in the `domain.properties` file to suit your environment, do not use the default values.
> [!TIP]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated to use the github notes type

@@ -101,8 +104,9 @@ EOF
podman run --rm -it -p 9002:9002 -p 7001:7001 --name wlsadmin --hostname wlsadmin -v ./domain.properties:/u01/oracle/properties/domain.properties container-registry.oracle.com/middleware/weblogic:14.1.2.0-generic-jdk21-ol9
```

> Note: This command runs the WebLogic Server 14.1.2 container with the admin server running on port 7001 and the management console running on port 9002. The domain properties file is mounted to the container to set the username and password for the WebLogic Server admin console.
> Change the username and password in the `domain.properties` file to suit your environment, do not use the default values.
> [!TIP]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated to use the github notes type


We'll step through this tutorial using the Spring Framework PetClinic example that is available on this GitHub repo: [`spring-framework-petclinic-12.2.1.4` sample](../../../samples/spring-framework-petclinic-12.2.1.4/). This is a fork of the approved [fork](https://github.com/spring-petclinic/spring-framework-petclinic/tree/5.3.x) from Spring Team, a Petclinic version with a plain Spring Framework 5.3.x configuration and with a 3-layer architecture (i.e. presentation --> service --> repository) and was modified to run on WebLogic 12.2.1.4 and 14.1.2.
We'll step through this tutorial using the Spring Framework PetClinic example that is available on this GitHub repo: [`spring-framework-petclinic-12.2.1.4`](../../../samples/spring-framework-petclinic-12.2.1.4/). This is a fork of the approved [fork](https://github.com/spring-petclinic/spring-framework-petclinic/tree/5.3.x) from the Spring Team, a PetClinic version with a plain Spring Framework 5.3.x configuration and with a 3-layer architecture (i.e. presentation --> service --> repository) and was modified to run on WebLogic 12.2.1.4 and 14.1.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include a note(TIP) saying that optionally you migrate the app to use with 15.1.1 Beta using the migration tutorial.

Tip

If you want to deploy the app to the WebLogic 15.1.1 beta ...

Copy link
Contributor Author

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosemarymarano rosemarymarano merged commit 3b1da53 into main Mar 4, 2025
1 check passed
@junior junior deleted the rm-review-spring1412-tutorial branch March 4, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants