Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #3334: build not finding YAJL #3335

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

RooHTaylor
Copy link
Contributor

When searching for YAJL during ./configure, pkg-config is checked first, and then a list of directories is searched if pkg-config bears no fruit. The previous version of yajl.m4 was looping over YAJL_POSSIBLE_LIB_NAMES instead of YAJL_POSSIBLE_PATHS and passing the lib name to the CHECK_FOR_YAJL_AT() function instead of the path. The would lead to YAJL never being found if pkg-config could not find it.

what

  • if pkg-config cannot locate libyajl it will not be located via path search, as the loop is passing lib names as path instead of possible paths.
  • change fixes loop definition to loop over paths instead of lib names.

why

  • so that libyajl may still be located if pkg-config fails

references

#3334

When searching for YAJL during ./configure, pkg-config is checked first,
and then a list of directories is searched if pkg-config bears no fruit.
The previous version of yajl.m4 was looping over YAJL_POSSIBLE_LIB_NAMES
instead of YAJL_POSSIBLE_PATHS and passing the lib name to the
CHECK_FOR_YAJL_AT() function instead of the path. The would lead to YAJL
never being found if pkg-config could not find it.
Copy link
Member

@airween airween left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks, @RooHTaylor!

@airween airween merged commit 40af573 into owasp-modsecurity:v3/master Jan 30, 2025
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants