Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2/refactor/default pcre2 #3345

Open
wants to merge 3 commits into
base: v2/master
Choose a base branch
from

Conversation

gberkes
Copy link
Contributor

@gberkes gberkes commented Mar 3, 2025

What

Refactor the build system and the relevant source files to make the PCRE2 library the default build target. If you wish to continue building with the legacy PCRE library, you must explicitly specify it using the following command:
configure --with-pcre.

Additional build system cleanups include:

Removed unnecessary AM_CONDITIONAL lines from configure.ac.

Why

The legacy PCRE library will be deprecated and eventually removed. The first step in this process is to make PCRE2 the default build dependency, replacing the old PCRE library.

Gábor Berkes added 3 commits March 1, 2025 07:31
Updated the build system and related source files to use libpcre2 as the
default regex library instead of the deprecated libpcre. This change
ensures future compatibility and aligns with the library's maintenance status.

To build with the old libpcre, the `--with-pcre` configuration parameter
can be specified.
Fix: Correct argument handling
Refactor: Remove unnecessary -DWITH_PCRE2 from CFLAGS
- Added .gitignore to track ignored files.
- Removed build/compile script generated by autogen.sh.
Copy link

sonarqubecloud bot commented Mar 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant