Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added error handling for division by zero #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions src/com/jwetherell/algorithms/mathematics/Division.java
Original file line number Diff line number Diff line change
@@ -3,11 +3,18 @@
public class Division {

public static final long division(int a, int b) {
if (b == 0) {
throw new IllegalArgumentException("Divisor cannot be zero.");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I see you changed this to add erroring handling! Great job!"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the problem of poor error handling by adding this.

}
long result = ((long) a) / ((long) b);
return result;
}

public static final long divisionUsingLoop(int a, int b) {
if (b == 0) {
throw new IllegalArgumentException("Divisor cannot be zero.");
}

int absA = Math.abs(a);
int absB = Math.abs(b);

@@ -22,6 +29,10 @@ public static final long divisionUsingLoop(int a, int b) {
}

public static final long divisionUsingRecursion(int a, int b) {
if (b == 0) {
throw new IllegalArgumentException("Divisor cannot be zero.");
}

int absA = Math.abs(a);
int absB = Math.abs(b);

@@ -38,6 +49,10 @@ public static final long divisionUsingRecursion(int a, int b) {
}

public static final long divisionUsingMultiplication(int a, int b) {
if (b == 0) {
throw new IllegalArgumentException("Divisor cannot be zero.");
}

int absA = Math.abs(a);
int absB = Math.abs(b);

@@ -55,27 +70,34 @@ public static final long divisionUsingMultiplication(int a, int b) {
}

public static final long divisionUsingShift(int a, int b) {
if (b == 0) {
throw new IllegalArgumentException("Divisor cannot be zero.");
}

int absA = Math.abs(a);
int absB = Math.abs(b);
int tempA, tempB, counter;

long result = 0L;
while (absA >= absB) {
tempA = absA >> 1; // Right shift "a"
tempA = absA >> 1;
tempB = absB;
counter = 1;
while (tempA >= tempB) { // Double "tempB" until it's larger than
// "tempA"
while (tempA >= tempB) {
tempB <<= 1;
counter <<= 1; // Double the counter
counter <<= 1;
}
absA -= tempB; // Subtract "tempB" from "a"
result += counter; // Add counter (2^number of left shifts)
absA -= tempB;
result += counter;
}
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result;
}

public static final long divisionUsingLogs(int a, int b) {
if (b == 0) {
throw new IllegalArgumentException("Divisor cannot be zero.");
}

long absA = Math.abs(a);
long absB = Math.abs(b);
double logBase10A = Math.log10(absA);