Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added divisor check for all division methods which throws runtime exception if divisor is zero #257

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hasn-Saeed
Copy link

Each division method located in src/com/jwetherell/algorithms/mathematics/Division.java has been updated with a check which ensures that division by 0 is not attempted. In case that a 0 has been sent to the method as the divisor, an IllegalArgumentException is thrown and a message is printed which indicates that the divisor cannot be 0.

By submitting this pull request I confirm I've read and complied with the below requirements.

  • [ x] I have read the Contribution guidelines and I am confident that my PR reflects them.
  • [ x] I have followed the coding guidelines for this project.
  • [ x] My code follows the skeleton code structure.
  • [ x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.

@Hasn-Saeed
Copy link
Author

Inserted a check in each division method which ensures that the divisor is not 0. In case that a 0 is sent, an IllegalArgumentException error is thrown and a message is displayed which explains that division by 0 cannot occur

Copy link
Author

@Hasn-Saeed Hasn-Saeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime exception triggered when division by 0 is attempted by any of the division methods within Division.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant