offsetgroup and alignmentgroup #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelle
reviewed
Nov 28, 2019
|
|
||
| fig.show() | ||
| ``` | ||
| Let's compare the impact of `offsetgroup` vs. `alignmentgroup`. |
There was a problem hiding this comment.
Could you please make this a title (Offsetgroup vs alignmentgroup) so that it appears in the nav bar and it's possible to link directly to this example? Same for the other traces.
emmanuelle
reviewed
Nov 28, 2019
| x = [1,2,3], | ||
| y = [2,3,4], | ||
| xaxis = 'x', | ||
| yaxis = 'y2')) |
There was a problem hiding this comment.
could you please define traces so that they use first "y" then "y2" etc.? The order can be a bit confusing.
emmanuelle
reviewed
Nov 28, 2019
| fig.update_layout( | ||
| xaxis = { | ||
| 'anchor': 'y'}, | ||
| yaxis2 = { |
There was a problem hiding this comment.
here could you define y before defining y2? No big deal, but it's just that these examples can be a bit long so it helps if things are always in an expected order. Same for the other examples.
|
Just a couple of minor comments, thank you! |
|
Can we port this PR to the plotly.py repo please? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.