Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTree: sel & isel add error context #10154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DataTree: sel & isel add error context #10154

wants to merge 1 commit into from

Conversation

mathause
Copy link
Collaborator

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

Have DataTree.sel and DataTree.isel report the node name if they error again. The example at the end of Operations and Methods on Trees suggests

Notice that the error raised helpfully indicates which node of the tree the operation failed on.

But this is no longer the case - add this context again.

@mathause mathause marked this pull request as ready for review March 20, 2025 10:14
@TomNicholas TomNicholas added topic-error reporting topic-DataTree Related to the implementation of a DataTree class labels Mar 20, 2025
@TomNicholas
Copy link
Member

TomNicholas commented Mar 20, 2025 •
edited
Loading

Nice catch! This could do with a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic-DataTree Related to the implementation of a DataTree class topic-error reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathause @TomNicholas