Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexing in convolve1d with mode="same" #1337

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

tvwenger
Copy link
Contributor

@tvwenger tvwenger commented Apr 1, 2025

Description

Fixes indexing issue introduced in convolve1d.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pytensor--1337.org.readthedocs.build/en/1337/

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (3af923b) to head (398e038).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files         203      203           
  Lines       48805    48805           
  Branches     8688     8688           
=======================================
  Hits        40026    40026           
  Misses       6627     6627           
  Partials     2152     2152           
Files with missing lines Coverage Δ
pytensor/tensor/signal/conv.py 97.05% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏, good catch

@ricardoV94 ricardoV94 merged commit afb7695 into pymc-devs:main Apr 1, 2025
66 of 67 checks passed
@tvwenger tvwenger deleted the convolve1d_same branch April 1, 2025 12:28
@ricardoV94 ricardoV94 added bug Something isn't working Op implementation labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Op implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants