-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-131798: Remove guard for known type in TO_BOOL_STR #131816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some style nitpicks. Can you also add a NEWS entry?
Also, I'm changing the issue number to GH-131798, since that fits better. |
Thanks, @brandtbucher! |
Stats look good. Looks like we're removing 25% of our |
|
Guard is unnecessary if we already know the value's type.
@brandtbucher