Missing try-before-set tests for datasink in etdumpgen tests #9551
Labels
good first issue
Good for newcomers
module: devtools
Issues related to developer tools and code under devtools/
🚀 The feature, motivation, and pitch
try-before-set tests are important for etdumpgen which avoids unexpected phenomenon when user using debug_buffer or datasink before setting it.
However right now we only have it in debug_buffer, but not in datasink
executorch/devtools/etdump/tests/etdump_test.cpp
Line 514 in 31d3545
The reason is, debug_buffer and datasinks are using a same etdumpgen in every inner for loop; after the first round even though we haven't set the datasink, it already has debug buffer that can handle the debug data dumping, so that error will not be raised.
possible solution
One solution is for every for-loop round, instead of sharing the same etdumpgen, we can use a different one, to bypass the issue.
We are open to any other solutions!
Please kindly leave your comments under the issue, or reach out to us via discord https://github.com/pytorch/executorch?tab=readme-ov-file#contributing, if you have any quesion.
The text was updated successfully, but these errors were encountered: