Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing try-before-set tests for datasink in etdumpgen tests #9551

Open
Gasoonjia opened this issue Mar 24, 2025 · 1 comment
Open

Missing try-before-set tests for datasink in etdumpgen tests #9551

Gasoonjia opened this issue Mar 24, 2025 · 1 comment
Labels
good first issue Good for newcomers module: devtools Issues related to developer tools and code under devtools/

Comments

@Gasoonjia
Copy link
Contributor

Gasoonjia commented Mar 24, 2025

🚀 The feature, motivation, and pitch

try-before-set tests are important for etdumpgen which avoids unexpected phenomenon when user using debug_buffer or datasink before setting it.

However right now we only have it in debug_buffer, but not in datasink

// TODO(gasoonjia): add similar ET_EXPECT_DEATH on BufferDataSink branch

The reason is, debug_buffer and datasinks are using a same etdumpgen in every inner for loop; after the first round even though we haven't set the datasink, it already has debug buffer that can handle the debug data dumping, so that error will not be raised.

possible solution

One solution is for every for-loop round, instead of sharing the same etdumpgen, we can use a different one, to bypass the issue.

We are open to any other solutions!

Please kindly leave your comments under the issue, or reach out to us via discord https://github.com/pytorch/executorch?tab=readme-ov-file#contributing, if you have any quesion.

@Gasoonjia Gasoonjia added good first issue Good for newcomers module: devtools Issues related to developer tools and code under devtools/ labels Mar 24, 2025
@keyprocedure
Copy link
Contributor

I’ll work on this and submit a PR once it’s ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers module: devtools Issues related to developer tools and code under devtools/
Projects
Development

No branches or pull requests

2 participants