Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make export llama checkpoint and param optional #9456

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

jackzhxng
Copy link
Contributor

Summary: Refactor to make checkpoint path and param path optional.

Differential Revision: D71404805

@jackzhxng jackzhxng requested a review from lucylq as a code owner March 20, 2025 16:41
Copy link

pytorch-bot bot commented Mar 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9456

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit e32991a with merge base 0dd7e4e (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 20, 2025
Summary:
Pull Request resolved: pytorch#9456

Refactor to make checkpoint path and param path optional.

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 20, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 20, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 20, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 20, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 21, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 21, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 21, 2025
Summary:
Pull Request resolved: pytorch#9456

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 21, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 21, 2025
Summary:
Pull Request resolved: pytorch#9456

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 21, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 22, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
jackzhxng added a commit to jackzhxng/executorch that referenced this pull request Mar 22, 2025
Summary:

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

Summary:
Pull Request resolved: pytorch#9456

Refactor to make checkpoint path and param path optional.

Reviewed By: larryliu0820

Differential Revision: D71404805
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71404805

@facebook-github-bot facebook-github-bot merged commit de0f6f1 into pytorch:main Mar 22, 2025
76 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants