-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate CoreML util and inmemoryfs targets to be reusable #9481
Draft
jathu
wants to merge
5
commits into
main
Choose a base branch
from
jathu/split-coreml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9481
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 Cancelled JobAs of commit 3172a23 with merge base 76ae537 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
larryliu0820
approved these changes
Mar 21, 2025
mergennachin
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
1f3966d
to
05b129a
Compare
mergennachin
approved these changes
Mar 21, 2025
d9f8ff5
to
639128b
Compare
jathu
commented
Mar 21, 2025
639128b
to
7f6cdc3
Compare
7f6cdc3
to
a03a108
Compare
b984672
to
73e3388
Compare
This reverts commit a03a108.
73e3388
to
c052251
Compare
c052251
to
3172a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ciflow/trunk
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
module: build/install
Issues related to the cmake and buck2 builds, and to installing ExecuTorch
topic: not user facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this diff, we separate the targets for
coreml/runtime/util
andcoreml/runtime/inmemoryfs
.Why?
As part of #9019, we want to support CoreML export out-of-the-box. Unfortunately, part of the workflow now includes installing an executorch+coreml binding as a pip wheel:
executorch/backends/apple/coreml/scripts/install_inmemoryfs.sh
Line 20 in 5fdfa51
This then gets used throughout the library. i.e.
executorch/backends/apple/coreml/compiler/coreml_preprocess.py
Line 19 in 5fdfa51
So we want to now bake this pybinding into the main wheel. Ultimately this
executorchcoreml
module, gets built using inmemoryfs:executorch/backends/apple/coreml/runtime/inmemoryfs/setup.py
Lines 17 to 38 in 5fdfa51
So, to enable creating a pybinding target, we must first decouple the
util
andinmemoryfs
libraries so they can be used incoremldelegate
and the future pybinding.Test plan
This should really be a no-op w.r.t. builds. So, CI +
cc @larryliu0820 @lucylq