Arm backend: Add all ops not supported on Ethos-U55 to support-check #9489
+20
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this includes ops that are not currently implemented. These ops are added for completeness. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I708db83e1af01d52e0a31e4285a1dd5d866e2749
Erik-Lundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9489
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 1b99762 with merge base e22b21a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
digantdesai
reviewed
Mar 21, 2025
| @@ -208,26 +208,41 @@ def is_node_supported( | |||
| class EthosU55NotSupported(OperatorSupportBase): | |||
| """ | |||
| Certain operators are not supported on U55. These are listed in `unsupported_ops`. | |||
| The comment mentions the unsupported TOSA operator that the aten operator maps to where it is not obvious. | |||
| For unimplemented operators, this is the anticipated mapping, and it might be incorrect. | |||
| """ | |||
|
|
|||
| unsupported_ops = [ | |||
There was a problem hiding this comment.
Curious why does this have to be a white-list? As opposed to all - supported?
There was a problem hiding this comment.
Hm. The current logic is that we have a list of (TOSA-)supported ops, a.k.a. ops that we have implemented. The support on Ethos-U55 is that list minus this list (and some additional constraints, these are just the completely unsupported ops) We don't have an explicit list of ops supported on Ethos-U55. Maybe I am missing your point 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this includes ops that are not currently implemented. These ops are added for completeness.